LGTM once comments are addressed. Is a similar change necessary for Intel platforms as well?
https://chromiumcodereview.appspot.com/10824235/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://chromiumcodereview.appspot.com/10824235/diff/1/src/arm/code-stubs-arm.cc#newcode1945 src/arm/code-stubs-arm.cc:1945: HeapNumber::kExponentOffset >> HeapNumber::kMantissaBitsInTopWord; kExponentOffset's unit is bytes (8 on 32-bit system), kMantissaBitsInTopWord (20). The result would be 0. Don't you mean kNaNOrInfinityLowerBoundUpper32 here? I guess it would be easier to read if we simply mask the exponent bits and compare to kNaNOrInfinityLowerBoundUpper32. https://chromiumcodereview.appspot.com/10824235/diff/1/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): https://chromiumcodereview.appspot.com/10824235/diff/1/src/arm/macro-assembler-arm.h#newcode116 src/arm/macro-assembler-arm.h:116: Condition cond = al); "Size" occurs twice in this method name. Intentional? https://chromiumcodereview.appspot.com/10824235/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
