https://chromiumcodereview.appspot.com/10824235/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right):
https://chromiumcodereview.appspot.com/10824235/diff/1/src/arm/code-stubs-arm.cc#newcode1945 src/arm/code-stubs-arm.cc:1945: HeapNumber::kExponentOffset >> HeapNumber::kMantissaBitsInTopWord; On 2012/08/10 09:57:11, Yang wrote:
kExponentOffset's unit is bytes (8 on 32-bit system),
kMantissaBitsInTopWord
(20). The result would be 0.
Don't you mean kNaNOrInfinityLowerBoundUpper32 here? I guess it would
be easier
to read if we simply mask the exponent bits and compare to kNaNOrInfinityLowerBoundUpper32.
Good catch. Changed to kExponentMask. https://chromiumcodereview.appspot.com/10824235/diff/1/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): https://chromiumcodereview.appspot.com/10824235/diff/1/src/arm/macro-assembler-arm.h#newcode116 src/arm/macro-assembler-arm.h:116: Condition cond = al); On 2012/08/10 09:57:11, Yang wrote:
"Size" occurs twice in this method name. Intentional?
Changed from PredictableSize to PredictableCodeSize to make the connection to predictable_code_size() more clear. https://chromiumcodereview.appspot.com/10824235/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
