http://codereview.chromium.org/10778029/diff/6001/src/deoptimizer.h File src/deoptimizer.h (right):
http://codereview.chromium.org/10778029/diff/6001/src/deoptimizer.h#newcode681 src/deoptimizer.h:681: if (value <= static_cast<uint32_t>(Smi::kMaxValue)) { Maybe having a Smi::IsValidUint(uint32_t value) method to mirror the existing Smi::IsValid and a Factory::NewNumberFromUInt method mirroring Factory::NewNumberFromInt would make the code a bit more readable (the INT32 and UINT32 cases would be coded in a similar way but calling different methods). http://codereview.chromium.org/10778029/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
