Fundamentally LGTM. However, if there is anyway to beef up the tests to make
sure that all of the cases in the uint32 tracking algorithm are covered,
please
add them.
http://codereview.chromium.org/10778029/diff/6001/test/mjsunit/compiler/uint32.js
File test/mjsunit/compiler/uint32.js (right):
http://codereview.chromium.org/10778029/diff/6001/test/mjsunit/compiler/uint32.js#newcode120
test/mjsunit/compiler/uint32.js:120: assertEquals(K4 | 0,
NonUint32Phi(false, K3, K4));
Please add tests for phi usages of phis.
http://codereview.chromium.org/10778029/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
