patch set 3 LGTM.
http://codereview.chromium.org/10918071/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/10918071/diff/1/src/ia32/macro-assembler-ia32.cc#newcode1961 src/ia32/macro-assembler-ia32.cc:1961: cmp(return_value, isolate()->factory()->undefined_value()); I guess you don't want to do a CmpInstanceType(map, ODDBALL_TYPE) because you want to exclude the hole from valid values, right? http://codereview.chromium.org/10918071/diff/2002/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/10918071/diff/2002/src/objects.cc#newcode214 src/objects.cc:214: #if 1 #if ENABLE_EXTRA_CHECKS maybe? http://codereview.chromium.org/10918071/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
