Landing...
http://codereview.chromium.org/10918071/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/10918071/diff/1/src/ia32/macro-assembler-ia32.cc#newcode1961 src/ia32/macro-assembler-ia32.cc:1961: cmp(return_value, isolate()->factory()->undefined_value()); On 2012/09/05 14:08:51, Jakob wrote:
I guess you don't want to do a CmpInstanceType(map, ODDBALL_TYPE)
because you
want to exclude the hole from valid values, right?
Yes, and things are stricter this way, because somebody could construct an odd Oddball. :-) http://codereview.chromium.org/10918071/diff/2002/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/10918071/diff/2002/src/objects.cc#newcode214 src/objects.cc:214: #if 1 On 2012/09/05 14:08:51, Jakob wrote:
#if ENABLE_EXTRA_CHECKS maybe?
Done. http://codereview.chromium.org/10918071/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
