Just nits.
https://chromiumcodereview.appspot.com/10909007/diff/18001/src/handles.cc File src/handles.cc (right): https://chromiumcodereview.appspot.com/10909007/diff/18001/src/handles.cc#newcode794 src/handles.cc:794: if (cache_result) object->map()->SetEnumLength(enum_size); I don't feel strongly about it, but for the record: I don't think we should convert if-statements to their one-line form. https://chromiumcodereview.appspot.com/10909007/diff/18001/src/objects-inl.h File src/objects-inl.h (right): https://chromiumcodereview.appspot.com/10909007/diff/18001/src/objects-inl.h#newcode1968 src/objects-inl.h:1968: // name->PrintLn(); nit: leftover? https://chromiumcodereview.appspot.com/10909007/diff/18001/src/objects-inl.h#newcode3032 src/objects-inl.h:3032: void Map::SetOwnsDescriptors(bool is_shared) { nit: for consistency, these two methods should be in unix_hacker_style. https://chromiumcodereview.appspot.com/10909007/diff/18001/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10909007/diff/18001/src/objects.cc#newcode5116 src/objects.cc:5116: // name->PrintLn(); leftover? https://chromiumcodereview.appspot.com/10909007/diff/18001/src/objects.cc#newcode5169 src/objects.cc:5169: // if (enumeration_index == number_of_descriptors()) return this; // ? https://chromiumcodereview.appspot.com/10909007/diff/18001/src/objects.cc#newcode5220 src/objects.cc:5220: // Resort if descriptors were removed. nit: s/Resort/Re-sort/ https://chromiumcodereview.appspot.com/10909007/diff/18001/src/objects.cc#newcode6025 src/objects.cc:6025: ASSERT(!IsEmpty()); // Do nothing for empty descriptor array. outdated comment (just remove it) https://chromiumcodereview.appspot.com/10909007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
