Drive-by LGTM (I just looked at the GC-related stuff).
https://chromiumcodereview.appspot.com/10909007/diff/18001/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/10909007/diff/18001/src/heap.cc#newcode2067 src/heap.cc:2067: int bit_field3 = 0; Can we use the following style here as well? int bit_field3 = Map::EnumLengthBits::encode(Map::kInvalidEnumCache) | Map::OwnsDescriptors::encode(true); https://chromiumcodereview.appspot.com/10909007/diff/18001/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10909007/diff/18001/src/mark-compact.cc#newcode1943 src/mark-compact.cc:1943: // We don't have to record the descriptors_pointer slot since the cellspace is Use s/cellspace/cell space/ in the comment, so we can grep for it. https://chromiumcodereview.appspot.com/10909007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
