http://codereview.chromium.org/10984057/diff/1/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right):
http://codereview.chromium.org/10984057/diff/1/src/arm/simulator-arm.cc#newcode1507 src/arm/simulator-arm.cc:1507: *carry_out = false; The carry_out should contain the last shifted bit according to the spec. http://codereview.chromium.org/10984057/diff/1/src/arm/simulator-arm.cc#newcode1511 src/arm/simulator-arm.cc:1511: We can remove this empty line. http://codereview.chromium.org/10984057/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/10984057/diff/1/src/hydrogen.cc#newcode1041 src/hydrogen.cc:1041: if (shl->UseCount()>1 || shr->UseCount()>1) return false; Please add space before and after each ">" operator. http://codereview.chromium.org/10984057/diff/1/src/hydrogen.cc#newcode1089 src/hydrogen.cc:1089: if (bor->left()->IsShl() && bor->right()->IsShr()) { Please add space before and after each ">" operator. http://codereview.chromium.org/10984057/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
