Hi Jay,
While waiting for the new revision of this patch set, I started prototyping
implementation of ROR for ia32 and x64 architectures, so that we can get
rid of
the ARM specific #ifdef in hydrogen.cc.
You can review the CL at https://chromiumcodereview.appspot.com/11033005/
Once you upload new patch set, we can combine both CLs to get something in
landable state.
I also added some tests and moved detection of the ROR pattern to the
visitor of
the bitwise OR. This seems cleaner to me than adding a new hydrogen phase
just
to detect one specific pattern, WDYT?
Please note that I checked the generated code but didn't check performance
on
StringSHA1 yet. How can I do this?
https://chromiumcodereview.appspot.com/10984057/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
