Revision: 12645
Author: [email protected]
Date: Mon Oct 1 10:16:00 2012
Log: Test runner: fix empty patches; better error message for missing
test files; correct .gitignore entry for message.status2
Review URL: https://codereview.chromium.org/11035004
http://code.google.com/p/v8/source/detail?r=12645
Modified:
/branches/bleeding_edge/.gitignore
/branches/bleeding_edge/tools/testrunner/network/endpoint.py
/branches/bleeding_edge/tools/testrunner/server/work_handler.py
=======================================
--- /branches/bleeding_edge/.gitignore Mon Sep 24 02:38:46 2012
+++ /branches/bleeding_edge/.gitignore Mon Oct 1 10:16:00 2012
@@ -29,7 +29,7 @@
/out/
/test/cctest/cctest.status2
/test/es5conform/data
-/test/messages/messages.status2
+/test/message/message.status2
/test/mjsunit/mjsunit.status2
/test/mozilla/CHECKED_OUT_VERSION
/test/mozilla/data
=======================================
--- /branches/bleeding_edge/tools/testrunner/network/endpoint.py Mon Sep 24
02:38:46 2012
+++ /branches/bleeding_edge/tools/testrunner/network/endpoint.py Mon Oct 1
10:16:00 2012
@@ -108,7 +108,15 @@
progress_indicator = EndpointProgress(sock, server, ctx)
runner = execution.Runner(suites, progress_indicator, ctx)
- runner.Run(server.jobs)
+ try:
+ runner.Run(server.jobs)
+ except IOError, e:
+ if e.errno == 2:
+ message = ("File not found: %s, maybe you forgot to 'git add' it?" %
+ e.filename)
+ else:
+ message = "%s" % e
+ compression.Send([-1, message], sock)
progress_indicator.HasRun(None) # Sentinel to signal the end.
progress_indicator.sender_lock.acquire() # Released when sending is
done.
progress_indicator.sender_lock.release()
=======================================
--- /branches/bleeding_edge/tools/testrunner/server/work_handler.py Mon
Oct 1 02:05:27 2012
+++ /branches/bleeding_edge/tools/testrunner/server/work_handler.py Mon
Oct 1 10:16:00 2012
@@ -128,6 +128,7 @@
return True
def _ApplyPatch(self, patch):
+ if not patch: return True # Just skip if the patch is empty.
patchfilename = "_dtest_incoming_patch.patch"
with open(patchfilename, "w") as f:
f.write(patch)
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
