Reviewers: danno, Michael Starzinger, Jay Conrod, Message: Please take a look.
https://chromiumcodereview.appspot.com/11033005/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://chromiumcodereview.appspot.com/11033005/diff/1/src/hydrogen-instructions.h#newcode902 src/hydrogen-instructions.h:902: bool deleteable_operation = IsBitwiseBinaryOperation(); danno, michael: any suggestions for other instruction types to add here? https://chromiumcodereview.appspot.com/11033005/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/11033005/diff/1/src/hydrogen.cc#newcode3414 src/hydrogen.cc:3414: HPhase phase("H_EliminateUnusedInstructions", this); Maybe I should just do one pass instead of this complex worklist algorithm? Description: Add rotate-right instruction to hydrogen and use it instead of bitwise operations of the form ((x >>> i) | (x << (32 - i))). This CL is based on https://chromiumcodereview.appspot.com/10984057/ by Jay Conrod <[email protected]>. [email protected],[email protected],[email protected] Please review this at https://chromiumcodereview.appspot.com/11033005/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/arm/lithium-arm.cc M src/arm/lithium-codegen-arm.cc M src/arm/simulator-arm.cc M src/hydrogen-instructions.h M src/hydrogen.h M src/hydrogen.cc M src/ia32/assembler-ia32.h M src/ia32/assembler-ia32.cc M src/ia32/lithium-codegen-ia32.cc M src/ia32/lithium-ia32.cc M src/token.h M src/x64/assembler-x64.h M src/x64/lithium-codegen-x64.cc M src/x64/lithium-x64.cc A test/mjsunit/compiler/rotate.js -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
