https://codereview.appspot.com/6591072/diff/1008/src/overrides.js
File src/overrides.js (right):

https://codereview.appspot.com/6591072/diff/1008/src/overrides.js#newcode24
src/overrides.js:24: String.prototype.localeCompare = function(that,
locales, options) {
This changes the enumerability.

Use Object.defineProperty instead

https://codereview.appspot.com/6591072/diff/1008/src/overrides.js#newcode24
src/overrides.js:24: String.prototype.localeCompare = function(that,
locales, options) {
This no longer reports the function as native.

assertEquals(String(String.prototype.toLocalString), 'function
toLocaleString() { [native code] }')

https://codereview.appspot.com/6591072/diff/1008/src/overrides.js#newcode26
src/overrides.js:26: return new Intl.Collator(locales,
options).compare(this, that);
How do we ensure that we are using the original Intl and Intl.Collator?

https://codereview.appspot.com/6591072/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to