LGTM with nits
https://codereview.appspot.com/6591072/diff/22001/src/overrides.js File src/overrides.js (right): https://codereview.appspot.com/6591072/diff/22001/src/overrides.js#newcode32 src/overrides.js:32: {value: function(that, locales, options) { Please fix indentation Object.defineProperty(String.prototype, 'localeCompare', { value: function(that, locales, options) { // Call internal method. return compare(new collator(locales, options), this, that); }, writable: true, configurable: true, enumerable: false }); https://codereview.appspot.com/6591072/diff/22001/tests/intl/overrides/security.js File tests/intl/overrides/security.js (right): https://codereview.appspot.com/6591072/diff/22001/tests/intl/overrides/security.js#newcode28 tests/intl/overrides/security.js:28: var throws = false; Isn't there an assertThrows? https://codereview.appspot.com/6591072/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
