https://codereview.chromium.org/11090021/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/11090021/diff/1/src/arm/macro-assembler-arm.cc#newcode3500 src/arm/macro-assembler-arm.cc:3500: Move(scratch, object); On 2012/10/09 13:09:21, jfb wrote:
Actually, let me retract my LGTM: this will generate an extra move on
non-ARMv7
machines. The move should be emitted with the same condition as Bfc: if (!CpuFeatures::IsSupported(ARMv7) || predictable_code_size())
Done. You are right, I totally missed that. https://codereview.chromium.org/11090021/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
