https://codereview.chromium.org/11090021/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/11090021/diff/1/src/arm/macro-assembler-arm.cc#newcode3501 src/arm/macro-assembler-arm.cc:3501: Bfc(scratch, 0, kPageSizeBits); On 2012/10/09 13:25:27, m.m.capewell wrote:
A more generic way of doing this, possibly with slightly better
performance, is
using two shifts, right then left, by kPageSizeBits.
So just to clarify. Do you think that the two-shift-approach would perform better than move+bfc on ARMv7? That would surprise me, but I am no ARM expert. My approach would be to always use move+bfc on ARMv7 and only use the two-shift-approach when we are running on non-ARMv7 and (lsb == 0). Need to find a non-ARMv7 device for measurements. https://codereview.chromium.org/11090021/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
