LGTM with nits pending performance numbers
http://codereview.chromium.org/11028115/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/11028115/diff/1/src/arm/macro-assembler-arm.cc#newcode3134 src/arm/macro-assembler-arm.cc:3134: tagged?TAG_OBJECT:NO_ALLOCATION_FLAGS); Spaces between ? and : http://codereview.chromium.org/11028115/diff/1/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/11028115/diff/1/src/arm/macro-assembler-arm.h#newcode735 src/arm/macro-assembler-arm.h:735: bool tagged = true); Use an enum here, like "enum TaggingMode { TAG_RESULT, DONT_TAG_RESULT }" , otherwise at the call site it's difficult to tell what the true/false actually means http://codereview.chromium.org/11028115/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
