http://codereview.chromium.org/11028115/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/11028115/diff/1/src/arm/macro-assembler-arm.cc#newcode3134
src/arm/macro-assembler-arm.cc:3134:
tagged?TAG_OBJECT:NO_ALLOCATION_FLAGS);
On 2012/10/10 12:27:53, danno wrote:
Spaces between ? and :
Done.
http://codereview.chromium.org/11028115/diff/1/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):
http://codereview.chromium.org/11028115/diff/1/src/arm/macro-assembler-arm.h#newcode735
src/arm/macro-assembler-arm.h:735: bool tagged = true);
On 2012/10/10 12:27:53, danno wrote:
Use an enum here, like "enum TaggingMode { TAG_RESULT, DONT_TAG_RESULT
}" ,
otherwise at the call site it's difficult to tell what the true/false
actually
means
Done.
http://codereview.chromium.org/11028115/diff/6001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
http://codereview.chromium.org/11028115/diff/6001/src/arm/lithium-codegen-arm.cc#newcode4692
src/arm/lithium-codegen-arm.cc:4692:
ASSERT(input->Equals(instrt->result()));
On 2012/10/11 13:03:57, danno wrote:
I think the above change is a typo.
Done.
http://codereview.chromium.org/11028115/diff/6001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/11028115/diff/6001/src/arm/stub-cache-arm.cc#newcode3809
src/arm/stub-cache-arm.cc:3809:
On 2012/10/11 13:03:57, danno wrote:
nit: remove introduced whitespace
Done.
http://codereview.chromium.org/11028115/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
