The CL generally looks good and also the test coverage is fine. But I think that
a mjsunit test using Object.defineProperty() would be easier to read while
giving similar coverage (just without the forced deletion). Would it be possible
for you to rewrite the current tests in JavaScript and put them in e.g.
mjsunit/delete-non-configurable.js (or a similar name). Also tests for strict
mode behavior might be useful in there.

https://codereview.chromium.org/11094021/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to