https://codereview.chromium.org/11094021/diff/3001/src/objects.cc File src/objects.cc (right):
https://codereview.chromium.org/11094021/diff/3001/src/objects.cc#newcode3946 src/objects.cc:3946: if (IsStringObjectWithCharacterAt(index)) { On 2012/10/15 15:25:34, Peter Varga wrote:
This is on purpose. Based on ECMA standard it should throw an
exception in
strict mode.
I totally agree but that wasn't the point of my comment. My comment is about this being in JSObject::DeleteProperty() where we didn't yet convert the property name into an index. That happens further down and the call is delegated to JSObject::DeleteElement() in those cases. It only makes sense to check whether we are accessing a character in a string after that point. Also it just doesn't compile here! :) https://codereview.chromium.org/11094021/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
