LGTM with nits.
http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc File src/deoptimizer.cc (right): http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc#newcode58 src/deoptimizer.cc:58: if (eager_deoptimization_entry_code_ != NULL) { nit: you can simplify this a bit by removing the condition. |delete| is safe to call on NULL pointers. Again below. http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc#newcode108 src/deoptimizer.cc:108: static const int kDeoptTableMaxEpilogueCodeSize = 2 * 1024; nit: 2 * KB http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc#newcode478 src/deoptimizer.cc:478: Address Deoptimizer::GetDeoptimizationEntry(int id, BailoutType type, nit: one line per argument http://codereview.chromium.org/11275145/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
