Feedback addressed, I will land this after verifying there's not performance regression.
http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc File src/deoptimizer.cc (right): http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc#newcode58 src/deoptimizer.cc:58: if (eager_deoptimization_entry_code_ != NULL) { On 2012/11/06 11:40:50, Jakob wrote:
nit: you can simplify this a bit by removing the condition. |delete|
is safe to
call on NULL pointers.
Again below.
Done. http://codereview.chromium.org/11275145/diff/8001/src/deoptimizer.cc#newcode478 src/deoptimizer.cc:478: Address Deoptimizer::GetDeoptimizationEntry(int id, BailoutType type, On 2012/11/06 11:40:50, Jakob wrote:
nit: one line per argument
Done. http://codereview.chromium.org/11275145/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
