https://chromiumcodereview.appspot.com/11360089/diff/2001/src/collection.js
File src/collection.js (right):
https://chromiumcodereview.appspot.com/11360089/diff/2001/src/collection.js#newcode91
src/collection.js:91: function SetSize() {
On 2012/11/06 09:32:40, Michael Starzinger wrote:
I think "SetGetSize" or "SetSizeGetter" would be a better naming
convention for
getters.
Done.
https://chromiumcodereview.appspot.com/11360089/diff/2001/src/collection.js#newcode235
src/collection.js:235: function DefineGetter(object, name, fun) {
On 2012/11/06 09:32:40, Michael Starzinger wrote:
Can we move this into v8natives.js near the implementation of
InstallFunctions,
so that it can become the bottle-neck for all builtin getters that we
install?
Done.
I also used a lower level abstraction.
https://chromiumcodereview.appspot.com/11360089/diff/2001/test/mjsunit/harmony/collections.js
File test/mjsunit/harmony/collections.js (right):
https://chromiumcodereview.appspot.com/11360089/diff/2001/test/mjsunit/harmony/collections.js#newcode319
test/mjsunit/harmony/collections.js:319: // Set and Map Set size
On 2012/11/06 09:32:40, Michael Starzinger wrote:
Comment seems to contain a typo.
Done.
https://chromiumcodereview.appspot.com/11360089/diff/2001/test/mjsunit/harmony/collections.js#newcode324
test/mjsunit/harmony/collections.js:324:
assertFalse(setSizeDescriptor.enumerable);
On 2012/11/06 09:32:40, Michael Starzinger wrote:
I couldn't find the expected value of the attributes (i.e. enumerable
and
configurable) in the draft spec. Is that still unspeced?
Last sentence of last paragraph in the introduction to clause 15:
Every other property described in this clause has the attributes {
[[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }
unless otherwise specified.
https://chromiumcodereview.appspot.com/11360089/diff/6/src/v8natives.js
File src/v8natives.js (right):
https://chromiumcodereview.appspot.com/11360089/diff/6/src/v8natives.js#newcode67
src/v8natives.js:67: %FunctionRemovePrototype(getter);
I missed this one last time. The spec says that all spec functions
unless, otherwise stated, should NOT have a prototype property.
https://chromiumcodereview.appspot.com/11360089/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
