LGTM. I'll land this for you.
https://chromiumcodereview.appspot.com/11360089/diff/2001/test/mjsunit/harmony/collections.js
File test/mjsunit/harmony/collections.js (right):
https://chromiumcodereview.appspot.com/11360089/diff/2001/test/mjsunit/harmony/collections.js#newcode324
test/mjsunit/harmony/collections.js:324:
assertFalse(setSizeDescriptor.enumerable);
On 2012/11/06 16:02:33, arv wrote:
On 2012/11/06 09:32:40, Michael Starzinger wrote:
> I couldn't find the expected value of the attributes (i.e.
enumerable and
> configurable) in the draft spec. Is that still unspeced?
Last sentence of last paragraph in the introduction to clause 15:
Every other property described in this clause has the attributes {
[[Writable]]:
true, [[Enumerable]]: false, [[Configurable]]: true } unless otherwise
specified.
Ah, yes, I didn't see this sentence. To be pedantic (as Andreas pointed
out), this sentence is talking about data properties (as it contains the
writable attribute) and it's unclear whether is also applies to accessor
properties. But I am fine to land this CL as it is even without a
clarification on this part.
https://chromiumcodereview.appspot.com/11360089/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
