LGTM except for formatting. I can fix that and land this.
In the future, please upload changes against https://v8.googlecode.com/svn/branches/bleeding_edge (see https://code.google.com/p/v8/wiki/UsingGit for instructions). Also, please use @chromium.org usernames for reviewers. https://codereview.appspot.com/6811090/diff/1/src/handles.cc File src/handles.cc (right): https://codereview.appspot.com/6811090/diff/1/src/handles.cc#newcode597 src/handles.cc:597: Isolate* isolate = script->GetIsolate(); nit: indentation https://codereview.appspot.com/6811090/diff/1/src/handles.cc#newcode607 src/handles.cc:607: NULL, &caught_exception); nit: indentation https://codereview.appspot.com/6811090/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
