On 2012/11/07 14:48:28, yangguo wrote:
https://codereview.appspot.com/6811090/diff/1/src/handles.cc
File src/handles.cc (right):
https://codereview.appspot.com/6811090/diff/1/src/handles.cc#newcode596
src/handles.cc:596: Handle<Object>
GetScriptNameOrSourceURL(Handle<Script>
script) {
I think handles.cc is the wrong place for this. Why not make this a
method of
Script and put it into object.h and object.cc?
On another thought, leaving it in handles.cc is probably alright, given
that a lot of other script-related stuff is there already. LGTM.
https://codereview.appspot.com/6811090/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
