LGTM with comments.
https://chromiumcodereview.appspot.com/11377132/diff/14003/src/builtins.cc File src/builtins.cc (right): https://chromiumcodereview.appspot.com/11377132/diff/14003/src/builtins.cc#newcode674 src/builtins.cc:674: // Get top element Simplify both cases to (if performance allows) ElementsAccessor* accessor = array->GetElementsAccessor(); int new_length = len - 1; MaybeObject* result = accessor->Get(array, array, new_length); if (result->IsFailure()) return result; MaybeObject* maybe_length = accessor->SetLength(array, new_length); if (maybe_length->IsFailure()) return maybe_length; if (!result->IsTheHole()) return result; https://chromiumcodereview.appspot.com/11377132/diff/14003/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/11377132/diff/14003/src/heap.cc#newcode4250 src/heap.cc:4250: elements_kind == FAST_HOLEY_DOUBLE_ELEMENTS) { IsFastDoubleElementsKind(elements_kind) https://chromiumcodereview.appspot.com/11377132/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
