First round.
https://codereview.chromium.org/11416238/diff/1001/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/11416238/diff/1001/src/builtins.cc#newcode1227 src/builtins.cc:1227: ElementsKind origin_kind = array->GetElementsKind(); Use "from_kind" as name for consistency. https://codereview.chromium.org/11416238/diff/1001/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/11416238/diff/1001/src/elements.cc#newcode1045 src/elements.cc:1045: return CopyElementsImpl(arguments, from_start, to, from_kind, Are you sure this is correct? This seems to only copy elements from the arguments backing store but ignore aliased arguments. Also it seems like the AliasedArgumentsEntry might escape through this path. https://codereview.chromium.org/11416238/diff/1001/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/11416238/diff/1001/src/objects-inl.h#newcode1749 src/objects-inl.h:1749: ElementsKind FixedArrayBase::GetElementsKind() { I don't like moving this outside of elements accessors. The only one who should be concerned about the elements kind for a certain backing store are elements accessors. That's why it belongs into that class. Please move it back. https://codereview.chromium.org/11416238/diff/1001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/11416238/diff/1001/src/objects.h#newcode2338 src/objects.h:2338: inline ElementsKind GetElementsKind(); See comments in objects-inl.h about this method. https://codereview.chromium.org/11416238/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
