LGTM if you address comments
https://codereview.chromium.org/11416238/diff/10002/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/11416238/diff/10002/src/elements.cc#newcode1005 src/elements.cc:1005: static ElementsKind ElementsKindForArray(FixedArrayBase* array) { Not sure how performance sensitive this is, but how about forcing this to inline, too? https://codereview.chromium.org/11416238/diff/10002/src/elements.cc#newcode1014 src/elements.cc:1014: return FAST_HOLEY_DOUBLE_ELEMENTS; How about a lookup array instead of the switch for the FIXED_ARRAY_TYPE case. Again, not sure if this is super performance critical, but it could be for copies of small site. https://codereview.chromium.org/11416238/diff/10002/src/elements.cc#newcode1079 src/elements.cc:1079: // This case should be UNREACHABLE(). Yikes, this is totally scary. https://codereview.chromium.org/11416238/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
