On 2012/11/07 22:42:41, danno wrote:
http://codereview.chromium.org/11369014/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
http://codereview.chromium.org/11369014/diff/1/src/arm/lithium-codegen-arm.cc#newcode4837
src/arm/lithium-codegen-arm.cc:4837: __ CompareMap(reg, scratch, map,
&success,
mode);
Why not pass in the map register here, too (to avoid extra loads of the
map),
since the optimization you applied below applies all callers of this
helper
method, too.
As per your suggestion, I am now passing the map register directly to
LCodeGen::DoCheckMapCommon.
Thanks!
https://codereview.chromium.org/11369014/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
