https://codereview.chromium.org/11369014/diff/5001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/11369014/diff/5001/src/arm/lithium-codegen-arm.cc#newcode4831 src/arm/lithium-codegen-arm.cc:4831: void LCodeGen::DoCheckMapCommon(Register scratch, can you please rename this to map_reg here and elsewhere to make it clear what it is? https://codereview.chromium.org/11369014/diff/5001/src/arm/lithium-codegen-arm.cc#newcode4850 src/arm/lithium-codegen-arm.cc:4850: __ ldr(scratch, FieldMemOperand(reg, HeapObject::kMapOffset)); can you please rename this to map_reg here and elsewhere to make it clear what it is? https://codereview.chromium.org/11369014/diff/5001/src/arm/lithium-codegen-arm.h File src/arm/lithium-codegen-arm.h (right): https://codereview.chromium.org/11369014/diff/5001/src/arm/lithium-codegen-arm.h#newcode134 src/arm/lithium-codegen-arm.h:134: void DoCheckMapCommon(Register scratch, Handle<Map> map, can you please rename this to map_reg here and elsewhere to make it clear what it is? https://codereview.chromium.org/11369014/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
