LGTM.
https://codereview.chromium.org/11477006/diff/3001/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/11477006/diff/3001/src/objects-inl.h#newcode1432 src/objects-inl.h:1432: if (IsJSArray()) JSArray::cast(this)->set_length(Smi::FromInt(0)); OMG, having to set the JSArray length to 0 here is extremely ugly. But I guess it is the most local hack that achieves this. https://codereview.chromium.org/11477006/diff/3001/test/mjsunit/harmony/object-observe.js File test/mjsunit/harmony/object-observe.js (right): https://codereview.chromium.org/11477006/diff/3001/test/mjsunit/harmony/object-observe.js#newcode28 test/mjsunit/harmony/object-observe.js:28: // Flags: --harmony-observation --harmony-proxies --harmony-collections --allow-natives-syntax You can have multiple "// Flags:" lines and thereby get by with 80 characters per line. https://codereview.chromium.org/11477006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
