https://codereview.chromium.org/11477006/diff/3001/src/objects-inl.h File src/objects-inl.h (right):
https://codereview.chromium.org/11477006/diff/3001/src/objects-inl.h#newcode1432 src/objects-inl.h:1432: if (IsJSArray()) JSArray::cast(this)->set_length(Smi::FromInt(0)); On 2012/12/11 15:20:19, Michael Starzinger wrote:
OMG, having to set the JSArray length to 0 here is extremely ugly. But
I guess
it is the most local hack that achieves this.
Yeah, the whole "abstraction" we have here is bogus, if you ask me. https://codereview.chromium.org/11477006/diff/3001/test/mjsunit/harmony/object-observe.js File test/mjsunit/harmony/object-observe.js (right): https://codereview.chromium.org/11477006/diff/3001/test/mjsunit/harmony/object-observe.js#newcode28 test/mjsunit/harmony/object-observe.js:28: // Flags: --harmony-observation --harmony-proxies --harmony-collections --allow-natives-syntax On 2012/12/11 15:20:19, Michael Starzinger wrote:
You can have multiple "// Flags:" lines and thereby get by with 80
characters
per line.
Done. https://codereview.chromium.org/11477006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
