What problem is this CL trying to solve? It's not really obvious.
Furthermore, I stopped adding comments about architecture-dependent stuff in
architecture-independent code parts at some point. Our architecture support
is
already a maintenance nightmare, and we should do *everything* to make it
better, not worse. If the CL is really potentially valuable for more than
one
platform, split it up cleanly in arch-dependendent and arch-independent
parts.
If it is not, completely hide the changes in src/x64.
https://codereview.chromium.org/11574027/diff/1/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/11574027/diff/1/src/assembler.cc#newcode296
src/assembler.cc:296: #if !defined(V8_TARGET_ARCH_X64)
Again for this and the rest of the file: No architecture-dependent stuff
should be here.
https://codereview.chromium.org/11574027/diff/1/src/assembler.h
File src/assembler.h (right):
https://codereview.chromium.org/11574027/diff/1/src/assembler.h#newcode244
src/assembler.h:244: #if defined(V8_TARGET_ARCH_X64)
Similar to the comment in the related CL, I will strongly object any
change in this area which is architecture-dependent.
https://codereview.chromium.org/11574027/diff/1/src/assembler.h#newcode261
src/assembler.h:261: #if defined(V8_TARGET_ARCH_X64)
see above
https://codereview.chromium.org/11574027/diff/1/src/assembler.h#newcode310
src/assembler.h:310: #if defined(V8_TARGET_ARCH_X64)
see above
https://codereview.chromium.org/11574027/diff/1/src/assembler.h#newcode362
src/assembler.h:362: #if defined(V8_TARGET_ARCH_X64)
see above
https://codereview.chromium.org/11574027/diff/1/src/assembler.h#newcode499
src/assembler.h:499: #if !defined(V8_TARGET_ARCH_X64)
see above
https://codereview.chromium.org/11574027/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/11574027/diff/1/src/flag-definitions.h#newcode303
src/flag-definitions.h:303: DEFINE_bool(disable_direct_deopt, false,
If we really need a flag (not sure about this), an "enable-style" flag
is prefered. Double negation is hard... ;-)
https://codereview.chromium.org/11574027/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
