Thanks for the patch.
Before I look in much more detail, please take a look and address my
high-level
concern about introducing platform-specific code in the common code-base.
https://codereview.chromium.org/11574027/diff/29001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/11574027/diff/29001/src/objects.cc#newcode8627
src/objects.cc:8627: #if defined(V8_TARGET_ARCH_X64)
I would very much like to avoid having platform #ifdefs in shared code.
I think a better solution is to add a new method of RelocInfo, something
like set_runtime_entry_address, which has a platform-specific
implementation and makes the offset relative on platforms that support
it, just like set_target_address does. With that in place, you could
always execute the code below, getting the "raw" address using a
specialized call similar to what code targets do above, e.g.:
Address p = it.rinfo()->absolute_runtime_entry_address(origin);
it.rinfo()->set_target_runtime_entry_address(origin);
https://codereview.chromium.org/11574027/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
