In general this is going the right way, I just have one high level comment
about
the interface. Also we need to make sure that the filtering doesn't regress
array operations on small or medium-sized arrays (not in large-object
space).
https://codereview.chromium.org/11737006/diff/4001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/11737006/diff/4001/src/heap.h#newcode528
src/heap.h:528: void MoveElements(FixedArray* dst, int dst_index,
FixedArray* src,
This method needs a comment explaining it's semantics. Also I would move
it down to the other FixedArray methods (e.g. somewhere around
CopyFixedArray).
The assumption is that whenever we move values in an object that "src ==
dst" holds. So I think it makes more sence to have an API that just
takes one object pointer, two offsets into it and one length. This also
makes further optimizations easier. WDYT?
https://codereview.chromium.org/11737006/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
