One additional comment for the record.

https://codereview.chromium.org/11737006/diff/4001/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/11737006/diff/4001/src/heap.cc#newcode690
src/heap.cc:690: if (!InNewSpace(src) && InNewSpace(dst_objects[i])) {
As discussed offline, this second loop is no longer cache-local because
it interleaves access to the store-buffer with access to the
destination. I am fine with landing this for now if it doesn't regress
until we optimize the store-buffer access, but please leave a TODO
comment here.

Also the InNewSpace(src) check can be hoisted out of the loop, because I
am not sure GCC is smart enough to do that.

https://codereview.chromium.org/11737006/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to