Revision: 13430
Author: [email protected]
Date: Fri Jan 18 04:44:36 2013
Log: tools/runtests.py: Fix cctests on Windows; properly return error
code when there were Python exceptions
Review URL: https://codereview.chromium.org/11929020
http://code.google.com/p/v8/source/detail?r=13430
Modified:
/branches/bleeding_edge/test/cctest/testcfg.py
/branches/bleeding_edge/tools/testrunner/local/execution.py
=======================================
--- /branches/bleeding_edge/test/cctest/testcfg.py Fri Oct 19 02:55:27 2012
+++ /branches/bleeding_edge/test/cctest/testcfg.py Fri Jan 18 04:44:36 2013
@@ -45,9 +45,9 @@
os.makedirs(self.serdes_dir)
def ListTests(self, context):
+ shell = os.path.abspath(os.path.join(context.shell_dir, self.shell()))
if utils.IsWindows():
shell += '.exe'
- shell = os.path.abspath(os.path.join(context.shell_dir, self.shell()))
output = commands.Execute([context.command_prefix,
shell,
'--list',
=======================================
--- /branches/bleeding_edge/tools/testrunner/local/execution.py Fri Oct 19
02:55:27 2012
+++ /branches/bleeding_edge/tools/testrunner/local/execution.py Fri Jan 18
04:44:36 2013
@@ -90,7 +90,7 @@
self.indicator.Starting()
self._RunInternal(jobs)
self.indicator.Done()
- if self.failed:
+ if self.failed or self.remaining:
return 1
return 0
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
