Revision: 13431
Author: [email protected]
Date: Fri Jan 18 05:05:03 2013
Log: Temporarily disable deferred stack trace formatting.
[email protected]
BUG=
Review URL: https://chromiumcodereview.appspot.com/11859027
http://code.google.com/p/v8/source/detail?r=13431
Modified:
/branches/bleeding_edge/src/heap.cc
/branches/bleeding_edge/src/isolate.cc
/branches/bleeding_edge/test/cctest/cctest.status
/branches/bleeding_edge/test/mjsunit/mjsunit.status
=======================================
--- /branches/bleeding_edge/src/heap.cc Thu Jan 17 06:31:03 2013
+++ /branches/bleeding_edge/src/heap.cc Fri Jan 18 05:05:03 2013
@@ -7288,6 +7288,7 @@
// Unforwarded objects in new space are dead and removed from the list.
void ErrorObjectList::UpdateReferencesInNewSpace(Heap* heap) {
+ if (list_.is_empty()) return;
if (!nested_) {
int write_index = 0;
for (int i = 0; i < list_.length(); i++) {
@@ -7315,7 +7316,7 @@
// If formatting the stack trace causes a GC, this method will be
// recursively called. In that case, skip the recursive call, since
// the loop modifies the list while iterating over it.
- if (nested_ || isolate->has_pending_exception()) return;
+ if (nested_ || list_.is_empty() || isolate->has_pending_exception())
return;
nested_ = true;
HandleScope scope(isolate);
Handle<String> stack_key = isolate->factory()->stack_symbol();
=======================================
--- /branches/bleeding_edge/src/isolate.cc Thu Jan 17 23:20:17 2013
+++ /branches/bleeding_edge/src/isolate.cc Fri Jan 18 05:05:03 2013
@@ -635,7 +635,6 @@
}
Handle<JSArray> result = factory()->NewJSArrayWithElements(elements);
result->set_length(Smi::FromInt(cursor));
- heap()->error_object_list()->Add(*error_object);
return result;
}
=======================================
--- /branches/bleeding_edge/test/cctest/cctest.status Wed Jan 2 07:00:12
2013
+++ /branches/bleeding_edge/test/cctest/cctest.status Fri Jan 18 05:05:03
2013
@@ -56,6 +56,9 @@
# We do not yet shrink weak maps after they have been emptied by the GC
test-weakmaps/Shrinking: FAIL
+# Deferred stack trace formatting is temporarily disabled.
+test-heap/ReleaseStackTraceData: PASS || FAIL
+
##############################################################################
[ $arch == arm ]
=======================================
--- /branches/bleeding_edge/test/mjsunit/mjsunit.status Thu Dec 20 08:31:19
2012
+++ /branches/bleeding_edge/test/mjsunit/mjsunit.status Fri Jan 18 05:05:03
2013
@@ -40,6 +40,9 @@
# Skip long running test in debug and allow it to timeout in release mode.
# regress/regress-524: (PASS || TIMEOUT), SKIP if $mode == debug
+# Deferred stack trace formatting is temporarily disabled.
+stack-traces-gc: PASS || FAIL
+
##############################################################################
# Too slow in debug mode with --stress-opt
compiler/regress-stacktrace-methods: PASS, SKIP if $mode == debug
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
