Reviewers: Michael Starzinger,
Description:
Hide addresses in traced code.
BUG=
Please review this at https://chromiumcodereview.appspot.com/12033007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/flag-definitions.h
M src/string-stream.cc
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
5bf7df3a5a51118966676ec9f655ec51098cfb32..4bc652968b63c16fb1d9121440225ca030bcc550
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -187,6 +187,7 @@ DEFINE_bool(collect_megamorphic_maps_from_stub_cache,
"crankshaft harvests type feedback from stub cache")
DEFINE_bool(hydrogen_stats, false, "print statistics for hydrogen")
DEFINE_bool(trace_hydrogen, false, "trace generated hydrogen to file")
+DEFINE_bool(trace_code_addresses, true, "trace hydrogen code addresses")
DEFINE_string(trace_phase, "Z", "trace generated IR for specified phases")
DEFINE_bool(trace_inlining, false, "trace inlining decisions")
DEFINE_bool(trace_alloc, false, "trace register allocator")
Index: src/string-stream.cc
diff --git a/src/string-stream.cc b/src/string-stream.cc
index
fc07d94ded237ee4ca79ebde48fe036680de6910..57386fef5abea2da1877ea4bacf965a4e41cc3b0
100644
--- a/src/string-stream.cc
+++ b/src/string-stream.cc
@@ -167,10 +167,14 @@ void StringStream::Add(Vector<const char> format,
Vector<FmtElm> elms) {
break;
}
case 'p': {
- void* value = current.data_.u_pointer_;
- EmbeddedVector<char, 20> formatted;
- OS::SNPrintF(formatted, temp.start(), value);
- Add(formatted.start());
+ if (FLAG_trace_code_addresses) {
+ void* value = current.data_.u_pointer_;
+ EmbeddedVector<char, 20> formatted;
+ OS::SNPrintF(formatted, temp.start(), value);
+ Add(formatted.start());
+ } else {
+ Add("0xXXXXXXXX");
+ }
break;
}
default:
@@ -206,7 +210,11 @@ void StringStream::PrintObject(Object* o) {
Add("#%d#", debug_object_cache->length());
debug_object_cache->Add(HeapObject::cast(o));
} else {
- Add("@%p", o);
+ if (FLAG_trace_code_addresses) {
+ Add("@%p", o);
+ } else {
+ Add("0xXXXXXXXX");
+ }
}
}
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
