Quick DBC. From a layering perspective this CL is ugly, because the client
of
the string stream should handle this, not the stream itself, but I can see
the
point of having a local (wrong) change...
https://chromiumcodereview.appspot.com/12033007/diff/1/src/string-stream.cc
File src/string-stream.cc (right):
https://chromiumcodereview.appspot.com/12033007/diff/1/src/string-stream.cc#newcode171
src/string-stream.cc:171: void* value = current.data_.u_pointer_;
I would prefer just a ternary ?: to calculate value (e.g. NULL when we
don't want to see the actual pointer) instead of the whole if/else.
https://chromiumcodereview.appspot.com/12033007/diff/1/src/string-stream.cc#newcode213
src/string-stream.cc:213: if (FLAG_trace_code_addresses) {
Do we really need this if we have the change above? It looks like this
is handled there already in an identical way.
https://chromiumcodereview.appspot.com/12033007/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
