Reviewers: Yang,
Description:
Moved FlagList::EnforceFlagImplications to V8::InitializeOncePerProcessImpl.
Cleaned up V8::InitializeOncePerProcessImpl a bit on the way.
Please review this at https://codereview.chromium.org/12045005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/v8.cc
Index: src/v8.cc
diff --git a/src/v8.cc b/src/v8.cc
index
b5aad90220b276dd3643ce14751e2119fda72a2e..6c86d8ebbaa9cf4484057c02ad0775c99b2b3e38
100644
--- a/src/v8.cc
+++ b/src/v8.cc
@@ -63,8 +63,6 @@ static EntropySource entropy_source;
bool V8::Initialize(Deserializer* des) {
- FlagList::EnforceFlagImplications();
-
InitializeOncePerProcess();
// The current thread may not yet had entered an isolate to run.
@@ -263,31 +261,20 @@ Object* V8::FillHeapNumberWithRandom(Object*
heap_number,
}
void V8::InitializeOncePerProcessImpl() {
- OS::SetUp();
-
- use_crankshaft_ = FLAG_crankshaft;
-
- if (Serializer::enabled()) {
- use_crankshaft_ = false;
- }
-
- CPU::SetUp();
- if (!CPU::SupportsCrankshaft()) {
- use_crankshaft_ = false;
- }
-
- OS::PostSetUp();
-
- RuntimeProfiler::GlobalSetUp();
-
- ElementsAccessor::InitializeOncePerProcess();
-
+ FlagList::EnforceFlagImplications();
if (FLAG_stress_compaction) {
FLAG_force_marking_deque_overflows = true;
FLAG_gc_global = true;
FLAG_max_new_space_size = (1 << (kPageSizeBits - 10)) * 2;
}
-
+ OS::SetUp();
+ CPU::SetUp();
+ use_crankshaft_ = FLAG_crankshaft
+ && !Serializer::enabled()
+ && CPU::SupportsCrankshaft();
+ OS::PostSetUp();
+ RuntimeProfiler::GlobalSetUp();
+ ElementsAccessor::InitializeOncePerProcess();
LOperand::SetUpCaches();
SetUpJSCallerSavedCodeData();
SamplerRegistry::SetUp();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
