Thanks for the comments and help!
https://codereview.chromium.org/11931037/diff/14001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/11931037/diff/14001/test/cctest/test-heap.cc#newcode2749 test/cctest/test-heap.cc:2749: ASSERT(limit != *limit_addr); On 2013/01/21 09:54:26, Michael Starzinger wrote:
I think we can drop the assertion whether the limit changed after a
GC. Done. https://codereview.chromium.org/11931037/diff/14001/test/cctest/test-heap.cc#newcode2757 test/cctest/test-heap.cc:2757: JSArray::kSize + AllocationSiteInfo::kSize + On 2013/01/21 09:54:26, Michael Starzinger wrote:
Wouldn't it be better to just allocate the array completely at the end
of
new-space without any allocation-site info and trailing pointer? This
should
still trigger the crash and on top of that make sure that the stub
doesn't read
a single pointer out of bounds. Also it would make the test case much
simpler. Actually in this case we do need it. The crash will only happen if we have <ARRAY> <AllocationSiteInfo> <kPointerSize filler>. There is a guard check in place, and without the extra bytes after the array, we won't enter the failure case. https://codereview.chromium.org/11931037/diff/20001/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/11931037/diff/20001/test/cctest/test-heap.cc#newcode2744 test/cctest/test-heap.cc:2744: Address* limit_addr = HEAP->new_space()->allocation_limit_address(); On 2013/01/21 12:21:07, ulan1 wrote:
Now that the assertion is removed, this code seems to unused.
Oh indeed, thanks for catching that Ulan! https://codereview.chromium.org/11931037/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
