lgtm with some nits
https://codereview.chromium.org/11931037/diff/10001/test/mjsunit/allocation-site-info.js File test/mjsunit/allocation-site-info.js (right): https://codereview.chromium.org/11931037/diff/10001/test/mjsunit/allocation-site-info.js#newcode84 test/mjsunit/allocation-site-info.js:84: function get_standard_literal() { nit: maybe just get_literal() https://codereview.chromium.org/11931037/diff/14001/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): https://codereview.chromium.org/11931037/diff/14001/src/ia32/macro-assembler-ia32.cc#newcode3058 src/ia32/macro-assembler-ia32.cc:3058: nit: discard the whitespace change https://codereview.chromium.org/11931037/diff/14001/test/mjsunit/allocation-site-info.js File test/mjsunit/allocation-site-info.js (right): https://codereview.chromium.org/11931037/diff/14001/test/mjsunit/allocation-site-info.js#newcode78 test/mjsunit/allocation-site-info.js:78: function fastliteralcase(literal, value) { 2 space indent for the "then" body of this function https://codereview.chromium.org/11931037/diff/14001/test/mjsunit/allocation-site-info.js#newcode79 test/mjsunit/allocation-site-info.js:79: // var literal = [1, 2, 3]; nit: remove the commented-out line above https://codereview.chromium.org/11931037/diff/14001/test/mjsunit/allocation-site-info.js#newcode81 test/mjsunit/allocation-site-info.js:81: return literal; 2 space indent above. https://codereview.chromium.org/11931037/diff/14001/test/mjsunit/allocation-site-info.js#newcode85 test/mjsunit/allocation-site-info.js:85: var literal = [1, 2, 3]; 2-space indent here and below https://codereview.chromium.org/11931037/diff/14001/test/mjsunit/allocation-site-info.js#newcode115 test/mjsunit/allocation-site-info.js:115: var literal = [1, 2, 3, 4]; nit: 2-space indent here too https://codereview.chromium.org/11931037/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
