Reviewers: Michael Starzinger,
Message:
Please take a look. The "weak embedded maps" flag is still set to false by
default.
https://chromiumcodereview.appspot.com/12094036/diff/2001/src/lithium.cc
File src/lithium.cc (right):
https://chromiumcodereview.appspot.com/12094036/diff/2001/src/lithium.cc#newcode459
src/lithium.cc:459: NoWeakEmbeddedMapsVerificationScope
disable_verification_of_embedded_maps;
I tried putting AlwaysAllocateScope here, but then some cc tests fail
because they already have AlwaysAllocateScope and we cannot nest them.
https://chromiumcodereview.appspot.com/12094036/diff/2001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://chromiumcodereview.appspot.com/12094036/diff/2001/src/mark-compact.cc#newcode2335
src/mark-compact.cc:2335: Object** slot =
codes->code_slot_at(new_number_of_codes);
This was the bug that lead to crashes.
Description:
Fix clearing of dead dependent codes and verify weak embedded maps on full
GC.
BUG=172488,172489
[email protected]
Please review this at https://chromiumcodereview.appspot.com/12094036/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/heap-inl.h
M src/heap.h
M src/heap.cc
M src/lithium.cc
M src/mark-compact.cc
M src/objects-inl.h
M src/objects-visiting-inl.h
M src/objects.h
M src/objects.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
