Reviewers: Jakob,
Description:
Fix Mac problem with stubs initialization
[email protected]
Please review this at https://codereview.chromium.org/12096040/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/lithium-codegen-arm.cc
M src/ia32/lithium-codegen-ia32.cc
M src/isolate.cc
M src/parser.cc
Index: src/arm/lithium-codegen-arm.cc
diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc
index
d9f82cea8edb1cea24d6f0532e12f538069ffcbc..134ec2d6787f4c92e4feca5e5ce3d972e338ce88
100644
--- a/src/arm/lithium-codegen-arm.cc
+++ b/src/arm/lithium-codegen-arm.cc
@@ -66,8 +66,6 @@ bool LCodeGen::GenerateCode() {
ASSERT(is_unused());
status_ = GENERATING;
- CodeStub::GenerateFPStubs();
-
// Open a frame scope to indicate that there is a frame on the stack.
The
// NONE indicates that the scope shouldn't actually generate code to set
up
// the frame (that is done in GeneratePrologue).
Index: src/ia32/lithium-codegen-ia32.cc
diff --git a/src/ia32/lithium-codegen-ia32.cc
b/src/ia32/lithium-codegen-ia32.cc
index
2e5fa56347105e9f97142dae783b058bd4406283..8cdf02fcd14996a0cf7e3f4f0d39a42e88e97a00
100644
--- a/src/ia32/lithium-codegen-ia32.cc
+++ b/src/ia32/lithium-codegen-ia32.cc
@@ -72,8 +72,6 @@ bool LCodeGen::GenerateCode() {
ASSERT(is_unused());
status_ = GENERATING;
- CodeStub::GenerateFPStubs();
-
// Open a frame scope to indicate that there is a frame on the stack.
The
// MANUAL indicates that the scope shouldn't actually generate code to
set up
// the frame (that is done in GeneratePrologue).
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index
1beaccd0e976ccd1a0769d6690decebe4a7bc348..f0eb36d2ca3e3a12172e2869be3a894f139fe483
100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2098,6 +2098,7 @@ bool Isolate::Init(Deserializer* des) {
if (!Serializer::enabled()) {
// Ensure that the stub failure trampoline has been generated.
HandleScope scope(this);
+ CodeStub::GenerateFPStubs();
StubFailureTrampolineStub().GetCode();
}
Index: src/parser.cc
diff --git a/src/parser.cc b/src/parser.cc
index
f6f84622e42e49386c8ad7bd8f6068ae1b1b1b3d..cb1d5073b08072add5bad9264185d7f74fafd0fa
100644
--- a/src/parser.cc
+++ b/src/parser.cc
@@ -52,7 +52,7 @@ namespace internal {
class PositionStack {
public:
explicit PositionStack(bool* ok) : top_(NULL), ok_(ok) {}
- ~PositionStack() { ASSERT(!*ok_ || is_empty()); }
+ ~PositionStack() { ASSERT(!*ok_ || is_empty()); USE(ok_); }
class Element {
public:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
