LGTM. I am fine with allocating a new map on each ObservationWeakMapCreate()
call for now as long as we have the TODO in there. It also makes the keyed
load
sites and some of the call sites in object-observe.js polymorphic I would
assume, but that overhead is negligible for now.
As for testing, there are unit tests in test-weakmaps.cc which test
weakness.
Unfortunately there is no way from within JavaScript to test the weakness
(at
least not without runtime helpers).
I would also wait for Andreas' blessing on this CL.
https://chromiumcodereview.appspot.com/12092079/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
