Drive by comments.
https://codereview.chromium.org/11659022/diff/50002/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/11659022/diff/50002/src/arm/lithium-codegen-arm.cc#newcode4579
src/arm/lithium-codegen-arm.cc:4579: if (!object_reg.is(r0)) {
Move(r0, object_reg);
https://codereview.chromium.org/11659022/diff/50002/src/arm/lithium-codegen-arm.cc#newcode4982
src/arm/lithium-codegen-arm.cc:4982: no_reg, vs);
Did you intend to make this vmov conditional?
https://codereview.chromium.org/11659022/diff/50002/src/arm/lithium-codegen-arm.cc#newcode5125
src/arm/lithium-codegen-arm.cc:5125: no_reg, vs);
same here, did you mean vmovvs?
https://codereview.chromium.org/11659022/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
