LGTM with two last comments about the test.
https://codereview.chromium.org/11659022/diff/37080/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):
https://codereview.chromium.org/11659022/diff/37080/test/mjsunit/mjsunit.status#newcode157
test/mjsunit/mjsunit.status:157: generated-transition-stub: PASS, SKIP
if $mode == debug
This is in the MIPS-only section, better move it up into the general
sections.
https://codereview.chromium.org/11659022/diff/37080/test/mjsunit/regress/generated-transition-stub.js
File test/mjsunit/regress/generated-transition-stub.js (right):
https://codereview.chromium.org/11659022/diff/37080/test/mjsunit/regress/generated-transition-stub.js#newcode1
test/mjsunit/regress/generated-transition-stub.js:1: // Copyright 2013
the V8 project authors. All rights reserved.
Not really a regression test, let's move it to either test/mjsunit or
test/mjsunit/compiler.
https://codereview.chromium.org/11659022/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
