LGTM if the comments are addressed.
https://chromiumcodereview.appspot.com/12177015/diff/3001/src/string.js
File src/string.js (left):
https://chromiumcodereview.appspot.com/12177015/diff/3001/src/string.js#oldcode285
src/string.js:285: search = TO_STRING_INLINE(search);
Looks like it was remove accidentally.
https://chromiumcodereview.appspot.com/12177015/diff/3001/src/string.js
File src/string.js (right):
https://chromiumcodereview.appspot.com/12177015/diff/3001/src/string.js#newcode271
src/string.js:271: SubString(subject, match[CAPTURE1], subject.length);
I would reformat by putting the first argument of ExpandReplacement in a
new line.
https://chromiumcodereview.appspot.com/12177015/diff/3001/src/string.js#newcode369
src/string.js:369: %_StringCharCodeAt(string, position + 1) != 49) { //
not '$01'
As discussed offline, we should check $02, ... $nn here too.
https://chromiumcodereview.appspot.com/12177015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
